-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normative: Add relative indexing method at() #2493
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
added
needs test262 tests
The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262
normative change
Affects behavior required to correctly evaluate some ECMAScript source text
pending stage 4
This proposal has not yet achieved stage 4, but may otherwise be ready to merge.
proposal
This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4.
labels
Aug 20, 2021
ljharb
reviewed
Aug 20, 2021
syg
added
has test262 tests
and removed
needs test262 tests
The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262
labels
Aug 20, 2021
bakkot
reviewed
Aug 20, 2021
This comment has been minimized.
This comment has been minimized.
syg
added
editor call
to be discussed in the next editor call
and removed
editor call
to be discussed in the next editor call
labels
Aug 25, 2021
bakkot
reviewed
Aug 27, 2021
bakkot
approved these changes
Aug 27, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than my s/?/!/
comment.
ljharb
added
has stage 4
This PR represents a proposal that has achieved stage 4, and is ready to merge.
and removed
pending stage 4
This proposal has not yet achieved stage 4, but may otherwise be ready to merge.
labels
Aug 31, 2021
michaelficarra
approved these changes
Sep 9, 2021
michaelficarra
added
ready to merge
Editors believe this PR needs no further reviews, and is ready to land.
and removed
editor call
to be discussed in the next editor call
labels
Sep 9, 2021
Adds Array#at, String#at, and %TypedArray%#at.
ljharb
force-pushed
the
relative-indexing-at
branch
from
September 9, 2021 23:27
b1a89e8
to
3aafa24
Compare
mathiasbynens
pushed a commit
to mathiasbynens/ecma262
that referenced
this pull request
Oct 18, 2021
Adds Array#at, String#at, and %TypedArray%#at.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
has stage 4
This PR represents a proposal that has achieved stage 4, and is ready to merge.
has test262 tests
normative change
Affects behavior required to correctly evaluate some ECMAScript source text
proposal
This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4.
ready to merge
Editors believe this PR needs no further reviews, and is ready to land.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds Array#at, String#at, and %TypedArray%#at.