Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normative: Add relative indexing method at() #2493

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Normative: Add relative indexing method at() #2493

merged 1 commit into from
Sep 9, 2021

Conversation

syg
Copy link
Contributor

@syg syg commented Aug 20, 2021

Adds Array#at, String#at, and %TypedArray%#at.

@syg syg requested a review from a team August 20, 2021 22:16
@ljharb ljharb added needs test262 tests The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262 normative change Affects behavior required to correctly evaluate some ECMAScript source text pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. labels Aug 20, 2021
ljharb
ljharb reviewed Aug 20, 2021
View reviewed changes
spec.html Outdated Show resolved Hide resolved
@syg
Copy link
Contributor Author

syg commented Aug 20, 2021 •
edited
Loading

This has tests:

https://github.com/tc39/test262/tree/main/test/built-ins/Array/prototype/at
https://github.com/tc39/test262/tree/main/test/built-ins/String/prototype/at
https://github.com/tc39/test262/tree/main/test/built-ins/TypedArray/prototype/at

@syg syg added has test262 tests and removed needs test262 tests The proposal should specify how to test an implementation. Ideally via github.com/tc39/test262 labels Aug 20, 2021
bakkot
bakkot reviewed Aug 20, 2021
View reviewed changes
spec.html Outdated Show resolved Hide resolved
@zloirock

This comment has been minimized.

Sign in to view
@syg syg added editor call to be discussed in the next editor call and removed editor call to be discussed in the next editor call labels Aug 25, 2021
bakkot
bakkot reviewed Aug 27, 2021
View reviewed changes
spec.html Outdated Show resolved Hide resolved
bakkot
bakkot approved these changes Aug 27, 2021
View reviewed changes
Copy link
Contributor

@bakkot bakkot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than my s/?/!/ comment.

@ljharb ljharb added has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. and removed pending stage 4 This proposal has not yet achieved stage 4, but may otherwise be ready to merge. labels Aug 31, 2021
@bakkot bakkot added the editor call to be discussed in the next editor call label Sep 8, 2021
@michaelficarra michaelficarra added ready to merge Editors believe this PR needs no further reviews, and is ready to land. and removed editor call to be discussed in the next editor call labels Sep 9, 2021
@syg @ljharb
Normative: Add relative indexing method at() (tc39#2493)
3aafa24 
Adds Array#at, String#at, and %TypedArray%#at.
@ljharb ljharb merged commit 3aafa24 into tc39:master Sep 9, 2021
@bakkot bakkot mentioned this pull request Sep 13, 2021
Closed
mathiasbynens pushed a commit to mathiasbynens/ecma262 that referenced this pull request Oct 18, 2021
@syg @mathiasbynens
Normative: Add relative indexing method at() (tc39#2493)
fbeb9ba 
Adds Array#at, String#at, and %TypedArray%#at.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb left review comments

@jmdyck jmdyck jmdyck left review comments

@michaelficarra michaelficarra michaelficarra approved these changes

@bakkot bakkot bakkot approved these changes

Assignees
No one assigned
Labels
has stage 4 This PR represents a proposal that has achieved stage 4, and is ready to merge. has test262 tests normative change Affects behavior required to correctly evaluate some ECMAScript source text proposal This is related to a specific proposal, and will be closed/merged when the proposal reaches stage 4. ready to merge Editors believe this PR needs no further reviews, and is ready to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@syg @zloirock @ljharb @michaelficarra @bakkot @jmdyck