Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Longer MQTT-Username #302

Closed
Sinned42 opened this issue Nov 3, 2022 · 9 comments
Closed

[Request] Longer MQTT-Username #302

Sinned42 opened this issue Nov 3, 2022 · 9 comments
Labels
enhancement New feature or request

Comments

@Sinned42
Copy link

Sinned42 commented Nov 3, 2022

Is your feature request related to a problem? Please describe.

I am using flespi.io as a broker for my MQTT.
Flespi.io uses tokens instead of Username and Password - unluckyly 64 characters, but only 32 characters are accepted.

Describe the solution you'd like

I suggest doing some changes in code:

configuration.h line 20
#define MQTT_MAX_USERNAME_STRLEN 64

MqqtAdminView.vue line 58
<input type="text" class="form-control" id="inputUsername" maxlength="64"

Best regards,
Sinned42

Describe alternatives you've considered

No response

Additional context

No response

@Sinned42 Sinned42 added the enhancement New feature or request label Nov 3, 2022
@tbnobody
Copy link
Owner

tbnobody commented Nov 3, 2022

This is something what I can implement after 15. Nov.
Please see #285
Currently this type is used to parse the binary blob for older devices. If I change this now it's no more possible for them to upgrade to the new config format.

@Sinned42
Copy link
Author

Sinned42 commented Nov 3, 2022

Perfect, thank you. Time doesn't matter, I put my username direct in MqttSettings.cpp and it worked so far for me.

@m0tschi
Copy link

m0tschi commented Nov 3, 2022

I appreciate it a lot, may you can do the same for the passwords? :)
thank you for all the improvements!

@OgerTours
Copy link

I check it with ee5b5b1 build and unfortunatly it's still not allowing to put more than 32 chars into username field.

Can some please check and/or confirm?

@tbnobody
Copy link
Owner

tbnobody commented Nov 19, 2022

What error message are you getting?

The UI itself allows a lot of characters...
image

PS: Did you refresh the web UI? (e.g. F5 or CTRL+F5)

@OgerTours
Copy link

Sorry, my stupid fault, I fully need to refresh the browser page, seems that browser was caching the page contnet and doesn't allow it to put more than 32 chars. Now it's working. Sorry for confusion.

@tbnobody
Copy link
Owner

May I ask which browser you are using? (With my Vivaldi which uses the chromium engine the ETAG headers are working pretty well and I just have to reload (just F5) the page to get the new changed content)

@OgerTours
Copy link

I use the Firefox Browser. You can perform a page reload with STRG+R or Shift+Click on the reload symbole.

stromibaer pushed a commit to stromibaer/OpenDTU-Victron that referenced this issue Nov 21, 2022
Changed max length from 32 to 64 characters
madmartin pushed a commit to madmartin/OpenDTU that referenced this issue Jul 16, 2023
Copy link

github-actions bot commented Apr 7, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new discussion or issue for related concerns.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants