Skip to content

Commit

Permalink
roachprod: improve error in ParallelE
Browse files Browse the repository at this point in the history
Prior to this commit, the error's stack trace did not link back
to the caller of `ParallelE`. Now it does.

Release note: None
  • Loading branch information
tbg committed Apr 12, 2022
1 parent 7a96183 commit d6a01b7
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion pkg/roachprod/install/cluster_synced.go
Original file line number Diff line number Diff line change
Expand Up @@ -2039,7 +2039,11 @@ func (c *SyncedCluster) ParallelE(
}

if len(failed) > 0 {
return failed, errors.New("one or more parallel execution failure")
var err error
for _, res := range failed {
err = errors.CombineErrors(err, res.Err)
}
return nil, errors.Wrap(err, "parallel execution failure")
}
return nil, nil
}
Expand Down

0 comments on commit d6a01b7

Please sign in to comment.