Skip to content

Commit

Permalink
storage: remove logging on GC suggestion
Browse files Browse the repository at this point in the history
These are expected during regular rebalancing activity and they can get
quite spammy, see for example:

cockroachdb#31622

Release note: None
  • Loading branch information
tbg committed Oct 30, 2018
1 parent 3e9a4e9 commit 1b2f6cb
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions pkg/storage/store.go
Original file line number Diff line number Diff line change
Expand Up @@ -3781,8 +3781,6 @@ func (s *Store) HandleRaftResponse(ctx context.Context, resp *RaftMessageRespons

if _, err := s.replicaGCQueue.Add(repl, replicaGCPriorityRemoved); err != nil {
log.Errorf(ctx, "unable to add to replica GC queue: %s", err)
} else {
log.Infof(ctx, "added to replica GC queue (peer suggestion)")
}
case *roachpb.RaftGroupDeletedError:
if replErr != nil {
Expand All @@ -3800,8 +3798,6 @@ func (s *Store) HandleRaftResponse(ctx context.Context, resp *RaftMessageRespons
// proper check.
if _, err := s.replicaGCQueue.Add(repl, replicaGCPriorityDefault); err != nil {
log.Errorf(ctx, "unable to add to replica GC queue: %s", err)
} else {
log.Infof(ctx, "added to replica GC queue (contacted deleted peer)")
}
case *roachpb.StoreNotFoundError:
log.Warningf(ctx, "raft error: node %d claims to not contain store %d for replica %s: %s",
Expand Down

0 comments on commit 1b2f6cb

Please sign in to comment.