Skip to content

Commit

Permalink
fix bitmask overflow when using slotted components (sveltejs#4077)
Browse files Browse the repository at this point in the history
  • Loading branch information
Conduitry authored and taylorzane committed Dec 17, 2020
1 parent 3fa2e11 commit 38e1b50
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/compiler/compile/render_dom/Renderer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -86,8 +86,6 @@ export default class Renderer {
null
);

this.context_overflow = this.context.length > 31;

// TODO messy
this.blocks.forEach(block => {
if (block instanceof Block) {
Expand All @@ -99,6 +97,8 @@ export default class Renderer {

this.fragment.render(this.block, null, x`#nodes` as Identifier);

this.context_overflow = this.context.length > 31;

this.context.forEach(member => {
const { variable } = member;
if (variable) {
Expand Down
3 changes: 3 additions & 0 deletions test/runtime/samples/bitmask-overflow-3/_config.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
export default {
error: `A is not defined`,
};
4 changes: 4 additions & 0 deletions test/runtime/samples/bitmask-overflow-3/main.svelte
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<script>
let x1, x2, x3, x4, x5, x6, x7, x8, x9, x10, x11, x12, x13, x14, x15, x16, x17, x18, x19, x20, x21, x22, x23, x24, x25, x26, x27, x28, x29, x30, x31;
</script>
<A>foo</A>

0 comments on commit 38e1b50

Please sign in to comment.