Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typos #477

Merged
merged 3 commits into from
Jan 26, 2017
Merged

fix typos #477

merged 3 commits into from
Jan 26, 2017

Conversation

gdh1995
Copy link
Contributor

@gdh1995 gdh1995 commented Jan 13, 2017

fix a typo of git message and another one mentioned in #459:

can't stop the move event L37 (e.interactable.off('move');)

There're 2 reasons making it fail, and one of them is a typo in Interactable.js and is fixed by the second commit in this PR.

Another one is that @emilkarl passed only one argument "move" to e.interactable.off at L37, so the third commit is added to make this usage work.

A message from `git stash` blocked the building process.
It should have called `this.events.off`
@gdh1995 gdh1995 force-pushed the master branch 2 times, most recently from 927a52b to 9f0ae6d Compare January 13, 2017 12:20
It may do this when the argument `listener` is `undefined`.
@taye taye merged commit a6e21ea into taye:master Jan 26, 2017
taye added a commit that referenced this pull request Jan 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants