Completed Assignment #84
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing datatype of variables
…me class using rollslist
tavisca-pchandan
requested changes
Jul 8, 2019
BowlingBall.Tests/GameTest.cs
Outdated
| namespace BowlingBall.Tests | ||
| { | ||
| public class GameTest | ||
| { |
There was a problem hiding this comment.
These all tests should be in file GameFixture.cs
BowlingBall.Tests/FrameTest.cs
Outdated
| @@ -0,0 +1,39 @@ | |||
| using System; | |||
There was a problem hiding this comment.
File name should be FrameFixture.cs
BowlingBall.Tests/GameTest.cs
Outdated
| [Fact] | ||
| public void RollWithPinsMoreThan10() | ||
| { | ||
| //roll cannot be more than 10 or negative |
There was a problem hiding this comment.
Create one private variable to hold instance of Game class and use that variable everywhere, rather than creating new game instance in every fixture
BowlingBall.Tests/SpareFrameTest.cs
Outdated
| using Xunit; | ||
| namespace BowlingBall.Tests | ||
| { | ||
| public class SpareFrameTest |
There was a problem hiding this comment.
Rename class as SpareFrameFixture
| using Xunit; | ||
| namespace BowlingBall.Tests | ||
| { | ||
| public class RegularFrameTest |
There was a problem hiding this comment.
Rename class as RegularFrameFixture
BowlingBall.Tests/SpareFrameTest.cs
Outdated
| //Negative roll shall throw exception | ||
| try | ||
| { | ||
| SpareFrame spareFrame = new SpareFrame(-1, -2,-8); |
BowlingBall.Tests/StrikeFrameTest.cs
Outdated
| { | ||
| public class StrikeFrameTest | ||
| { | ||
|
|
There was a problem hiding this comment.
Rename class to StrikeFrameFixture
| @@ -0,0 +1,150 @@ | |||
| using System; | |||
There was a problem hiding this comment.
Why you have added 'The' in class name????
Also rename it to 'BowlingGameFixture'
| [Fact] | ||
| public void ScoreCannotBeMoreThan300() | ||
| { | ||
| ArrayList rolls = new ArrayList(); |
…to hold instance of Game
…private variable to hold instance of RegularFrame
… every local variable declaration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.