Add files via upload #85
Conversation
Final result
There was a problem hiding this comment.
Try to break the solution into logical units.
Create separate methods having single responsibility so that they are short, readable and easy to maintain.
Try to use .net library methods as and when available instead of re-inventing the wheel e.g. string.Split(), int.TryParse(), string.IndexOf().
Optimize number of iterations and number of if else and nesting in code.
| { | ||
| int len = equation.length(); | ||
| char[] val = sentence.ToCharArray(); | ||
| int i,j=0,k=0,l=0,asum=0,bsum=0,csum=0,fin=0,countr,q,ques,mul,eql; |
There was a problem hiding this comment.
use meaningful names for variables which convey their purpose
| int len = equation.length(); | ||
| char[] val = sentence.ToCharArray(); | ||
| int i,j=0,k=0,l=0,asum=0,bsum=0,csum=0,fin=0,countr,q,ques,mul,eql; | ||
| for(i=0;i<len;i++) |
There was a problem hiding this comment.
code is very difficult to follow. lot of for loops and if else conditions in code, everything written in a single method which is more than 100 lines of code.
| if(int_result % int_secondnum==0) | ||
| { | ||
| string temp = (int_result / int_secondnum) + ""; | ||
| newEquation += temp + "*" + second_num + "=" + result; |
There was a problem hiding this comment.
why create the equation again. you have got the integer value of missing number by division and you have the string value with ? already, so just take indexof ? and return value at same index from the calculated missing number converted to string
|
|
||
| public static int FindDigit(string equation) | ||
| { | ||
| string first_num = equation.Split('*')[0]; |
There was a problem hiding this comment.
do not use snake casing, use camel casing for local variable names e.g. firstNumber
| string second_num = equation.Split('*')[1].Split('=')[0]; | ||
| string result = equation.Split('=')[1]; | ||
|
|
||
| bool ques_in_first = Int32.TryParse(first_num, out int int_firstnum); |
| newEquation += first_num + "*" + second_num + "=" + temp; | ||
| } | ||
|
|
||
| if (equation.Length != newEquation.Length) |
There was a problem hiding this comment.
all this wont be needed, refer the comment about logic
| public static int FindDigit(string equation) | ||
| { | ||
| string first_num = equation.Split('*')[0]; | ||
| string second_num = equation.Split('*')[1].Split('=')[0]; |
There was a problem hiding this comment.
use array of '*' and '=' to split string in a single operation and store in array. this array[0], [1] and [2] will give you a, b and c
No description provided.