Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prerender post open graph images #1

Closed
wants to merge 7 commits into from
Closed

Conversation

taverasmisael
Copy link
Owner

No description provided.

@netlify
Copy link

netlify bot commented May 27, 2023

Deploy Preview for transcendent-jalebi-325545 failed.

Name Link
🔨 Latest commit 32c6532
🔍 Latest deploy log https://app.netlify.com/sites/transcendent-jalebi-325545/deploys/6472102236e904000843a9e1

@taverasmisael
Copy link
Owner Author

It was not possible to make Netlify's functions work. It seems related to esbuild not supporting top-level awaits and "astro:assets", outputting a top-level await to get some images. This is technically not wrong because the files are .mjs, but esbuild and Netlify don't support that feature yet.

As this is an issue with Astro's experimental assets feature and the code is autogenerated, there's no much to do.

There's the not-at-all-good alternative to stop using the assets experimental and use @astro/images, but that's also experimental and doesn't have the optimizations the assets' integration has. I'll have to update all the references to images in all the posts, which is also not ideal because hopefully in the future, the assets' integration will replace the images anyway.

I'm trying with Vercel now; if not, I'll use the node adapter and move this to a service like fly.io or something.

More context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant