Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add request body on Linux #969

Merged
merged 3 commits into from
Jun 13, 2023
Merged

feat: add request body on Linux #969

merged 3 commits into from
Jun 13, 2023

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Jun 9, 2023 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

You can test with form example.
Don't merge this yet! There are a lot of new deprecated methods in 2.40. We should fix them before merging.

@wusyong wusyong requested a review from a team as a code owner June 9, 2023 14:11
amrbashir
amrbashir previously requested changes Jun 9, 2023
View reviewed changes
src/webview/webkitgtk/web_context.rs Show resolved Hide resolved
@lucasfernog lucasfernog mentioned this pull request Jun 11, 2023
Merged
13 tasks
@lucasfernog
Copy link
Member

Btw I tested this and it works well, nice one!

@wusyong wusyong requested review from amrbashir and lucasfernog June 12, 2023 14:22
@wusyong wusyong dismissed amrbashir’s stale review June 13, 2023 03:36

The request has been approved.

@wusyong wusyong merged commit d2c1819 into dev Jun 13, 2023
@wusyong wusyong deleted the linux-body branch June 13, 2023 03:36
@github-actions github-actions bot mentioned this pull request Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FabianLars FabianLars FabianLars left review comments

@lucasfernog lucasfernog lucasfernog approved these changes

@amrbashir amrbashir Awaiting requested review from amrbashir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wusyong @lucasfernog @FabianLars @amrbashir