Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(macos): use WKWebView's inspectable property #923

Merged
merged 1 commit into from
Apr 9, 2023

Conversation

lucasfernog
Copy link
Member

Ref tauri-apps/tauri#6658

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve tauri-apps/tauri#6658
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner April 8, 2023 15:38
@keeganstothert
Copy link

keeganstothert commented Apr 8, 2023

i could be missing something but I pulled this branch and added wry to deps to build locally

[dependencies]
...
wry = { path = "/Users/self/Repositories/wry" }

I nuked gen and target and ran init again.

still unable to to connect inspector to device or sim.

image

no inspectable applications

safari technology preview 16.4 release 167

you can ignore this it seems a patch was needed, it's working now!

wry = "0.27.2"

[patch.crates-io]
wry = { path = "/Users/keeganstothert/Repositories/wry" }

@wusyong wusyong merged commit c3f7304 into dev Apr 9, 2023
@wusyong wusyong deleted the feat/wkwebview-inspectable branch April 9, 2023 02:38
@github-actions github-actions bot mentioned this pull request Apr 9, 2023
@github-actions github-actions bot mentioned this pull request May 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants