Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve android env vars naming #829

Merged
merged 2 commits into from
Dec 30, 2022
Merged

refactor: improve android env vars naming #829

merged 2 commits into from
Dec 30, 2022

Conversation

dvc94ch
Copy link
Contributor

@dvc94ch dvc94ch commented Dec 29, 2022

Renames the wry environment variables to WRY_ANDROID_PACKAGE and WRY_ANDROID_LIBRARY. These make the intent clearer. Also avoids wry adding an unwanted postfix to the package name (app-snake-case-name).

@dvc94ch dvc94ch requested a review from a team as a code owner December 29, 2022 17:10
amrbashir
amrbashir approved these changes Dec 30, 2022
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@amrbashir amrbashir changed the title Improve naming. refactor: improve android env vars naming Dec 30, 2022
@amrbashir amrbashir merged commit dfe6a5e into tauri-apps:dev Dec 30, 2022
@github-actions github-actions bot mentioned this pull request Dec 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvc94ch @amrbashir