Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add document title changed handler, closes #804 #825

Merged
merged 9 commits into from
Dec 30, 2022
Merged

feat: add document title changed handler, closes #804 #825

merged 9 commits into from
Dec 30, 2022

Conversation

amrbashir
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir force-pushed the document-title-changed-handler branch from 2bead5f to 79596e6 Compare December 27, 2022 12:38
@amrbashir amrbashir force-pushed the document-title-changed-handler branch from b622a93 to b63ef48 Compare December 27, 2022 12:45
@amrbashir amrbashir marked this pull request as ready for review December 27, 2022 12:53
@amrbashir amrbashir requested a review from a team as a code owner December 27, 2022 12:53
wusyong
wusyong requested changes Dec 29, 2022
View reviewed changes
src/webview/wkwebview/mod.rs Outdated Show resolved Hide resolved
@amrbashir amrbashir merged commit 14a0ee3 into dev Dec 30, 2022
@amrbashir amrbashir deleted the document-title-changed-handler branch December 30, 2022 18:47
@github-actions github-actions bot mentioned this pull request Dec 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong requested changes

@lucasfernog lucasfernog lucasfernog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrbashir @wusyong @lucasfernog