Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Remove redundant .clone() calls and avoid unnecessary heap allocations #812

Merged
merged 1 commit into from
Dec 14, 2022
Merged

perf: Remove redundant .clone() calls and avoid unnecessary heap allocations #812

merged 1 commit into from
Dec 14, 2022

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Dec 14, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This patch removes redundant .clone() calls and unnecessary heap allocations.

@rhysd rhysd requested a review from a team as a code owner December 14, 2022 00:39
@wusyong wusyong merged commit 45f2b21 into tauri-apps:dev Dec 14, 2022
@github-actions github-actions bot mentioned this pull request Dec 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rhysd @wusyong