Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___
)Other information
All I did was have the
WryWebViewParent
callperformKeyEquivalent
on themenu
. As far as I can tell, everything works:Escape
keydown eventsCopy
can still beep, but that's correct behavior - Safari acts the same. You can prevent the menu (and by extension, the beep) from being called usinge.preventDefault()
in the frontend.Q
andCtrl+Shift+Q
menus workCloses #799
@wusyong Is there anything I'm missing?