Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): Fix typo in method name of WebViewBuilderExtWindows #781

Merged
merged 3 commits into from
Dec 1, 2022

Conversation

rhysd
Copy link
Contributor

@rhysd rhysd commented Dec 1, 2022

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@rhysd rhysd requested a review from a team as a code owner December 1, 2022 12:31
@rhysd
Copy link
Contributor Author

rhysd commented Dec 1, 2022

Though changing method names is a breaking change, I believe the usage of this method is very rare hence it does not affect users actually:

https://github.com/search?q=additionl_browser_args&type=code

amrbashir
amrbashir previously approved these changes Dec 1, 2022
@amrbashir
Copy link
Member

Thank you

@amrbashir amrbashir merged commit db1c290 into tauri-apps:dev Dec 1, 2022
@github-actions github-actions bot mentioned this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants