feat(android): validate custom protocol response status code #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wusyong
reviewed
Nov 30, 2022
| } else if status_code > 599 { | ||
| Some("statusCode can't be greater than 599.") | ||
| } else if status_code > 299 && status_code < 400 { | ||
| Some("statusCode can't be in the [300, 399] range.") |
There was a problem hiding this comment.
I guess Android can't handle redirects. I just took this from their own code, see the link in the PR description.
There was a problem hiding this comment.
should probably document that with a link to their docs/code
wusyong
approved these changes
Nov 30, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
On Android, using an invalid status code results in a crash. See https://android.googlesource.com/platform/frameworks/base/+/master/core/java/android/webkit/WebResourceResponse.java#144