Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macos): do not trigger unsupported key feedback sound on keypress #742

Merged
merged 1 commit into from
Oct 30, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

Ref tauri-apps/tauri#2626

@lucasfernog lucasfernog requested a review from a team as a code owner October 28, 2022 18:28
@amrbashir amrbashir merged commit 51c7f12 into dev Oct 30, 2022
@amrbashir amrbashir deleted the fix/macos-keypress-sound branch October 30, 2022 11:39
@github-actions github-actions bot mentioned this pull request Oct 30, 2022
@wusyong
Copy link
Member

wusyong commented Oct 31, 2022

I had a discussion with Lucas and the reason I didn't merge this is because I got a warning:
TSM AdjustCapsLockLEDForKeyTransitionHandling - _ISSetPhysicalKeyboardCapsLockLED Inhibit
This seems to be CJK IME only. The answer on SO isn't pretty helpful. They said just don't use Caplocks for input switching.

@lucasfernog
Copy link
Member Author

Maybe it's because we're not passing the event to the system input manager with interpretKeyEvents. The winit approach is much more complicated, see the code.

@wusyong
Copy link
Member

wusyong commented Nov 2, 2022

I didn't see any significant error and the input seems intact. I'll pass this until we see any issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants