Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cross compilation. #731

Merged
merged 2 commits into from
Oct 29, 2022
Merged

Fix cross compilation. #731

merged 2 commits into from
Oct 29, 2022

Conversation

dvc94ch
Copy link
Contributor

@dvc94ch dvc94ch commented Oct 22, 2022

this is one of the patches that let's dioxus apps be built for ios with xbuild.

@dvc94ch dvc94ch requested a review from a team as a code owner October 22, 2022 13:40
Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you add a .change file?

@dvc94ch
Copy link
Contributor Author

dvc94ch commented Oct 24, 2022

Like this? I'm not sure what a .change file is. Added an entry to the change log. If this is ok I'll do the other PR too.

@dvc94ch
Copy link
Contributor Author

dvc94ch commented Oct 24, 2022

Ah ok think I figured it out

.changes/crosscompile.md Outdated Show resolved Hide resolved
@dvc94ch dvc94ch force-pushed the xbuild branch 2 times, most recently from c1e6492 to 47ce7b9 Compare October 24, 2022 11:02
@wusyong wusyong merged commit cd08410 into tauri-apps:dev Oct 29, 2022
@github-actions github-actions bot mentioned this pull request Oct 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants