Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(webview2): hide the webview when the window is minimized #702

Merged
merged 2 commits into from
Sep 27, 2022
Merged

feat(webview2): hide the webview when the window is minimized #702

merged 2 commits into from
Sep 27, 2022

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Sep 21, 2022 •
edited
Loading

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

@amrbashir amrbashir requested a review from a team as a code owner September 21, 2022 12:07
@amrbashir amrbashir merged commit 51b49c5 into dev Sep 27, 2022
@amrbashir amrbashir deleted the hide-webview2 branch September 27, 2022 19:28
@github-actions github-actions bot mentioned this pull request Sep 27, 2022
Merged
amrbashir added a commit that referenced this pull request Oct 27, 2022
@amrbashir
fix: restore webview2 visibility upon restoring a maximized window
541e606 
regression was introduce in #702
@amrbashir amrbashir mentioned this pull request Oct 27, 2022
Merged
13 tasks
amrbashir added a commit that referenced this pull request Oct 27, 2022
@amrbashir
fix: restore webview2 visibility upon restoring a maximized window (#738
225d0c9 
)

regression was introduce in #702
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@amrbashir