fix: devtool warning by adding parent view, closes #273 #654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would just inject the webview into the contentView of the NSWindow. When devtools would inject the subView into this top-level content view, a warning would be displayed.
|
Thank you for your contribution. |
|
I think this will reintroduce the cursor bug. |
|
It doesn't seem to reintroduce it. (And I am able to reproduce #220 when changing to a commit before d550b2f, so it doesn't seem like it's related to just my environment.) It seems the actual fix for d550b2f is to avoid using the ns_view created by tao. So it seems there's likely a bug there in tao, and the workaround introduced here and in d550b2f should be reverted once that's fixed. |
wusyong
approved these changes
Aug 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information