Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add function to close the devtool and check if it is opened #529

Merged
merged 12 commits into from
Mar 28, 2022
Merged

feat: add function to close the devtool and check if it is opened #529

merged 12 commits into from
Mar 28, 2022

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes, and the changes were approved in issue #___
  • No

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

This allows an user to implement shortcuts to open/close the devtools.

@lucasfernog lucasfernog requested review from a team March 27, 2022 13:42
@lucasfernog lucasfernog requested a review from a team as a code owner March 27, 2022 13:42
wusyong
wusyong previously approved these changes Mar 27, 2022
View reviewed changes
amrbashir
amrbashir requested changes Mar 27, 2022
View reviewed changes
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also change all devtool to devtools in all the functions?

src/webview/mod.rs Outdated Show resolved Hide resolved
src/webview/mod.rs Outdated Show resolved Hide resolved
src/webview/mod.rs Outdated Show resolved Hide resolved
src/webview/wkwebview/mod.rs Outdated Show resolved Hide resolved
src/webview/wkwebview/mod.rs Outdated Show resolved Hide resolved
amrbashir
amrbashir reviewed Mar 27, 2022
View reviewed changes
src/webview/mod.rs Outdated Show resolved Hide resolved
amrbashir
amrbashir requested changes Mar 28, 2022
View reviewed changes
.changes/is-devtool-visible.md Outdated Show resolved Hide resolved
src/webview/android/mod.rs Outdated Show resolved Hide resolved
src/webview/mod.rs Outdated Show resolved Hide resolved
src/webview/webkitgtk/mod.rs Outdated Show resolved Hide resolved
src/webview/webkitgtk/mod.rs Outdated Show resolved Hide resolved
src/webview/webkitgtk/mod.rs Outdated Show resolved Hide resolved
src/webview/webkitgtk/mod.rs Outdated Show resolved Hide resolved
src/webview/webview2/mod.rs Outdated Show resolved Hide resolved
src/webview/mod.rs Outdated Show resolved Hide resolved
src/webview/wkwebview/mod.rs Outdated Show resolved Hide resolved
amrbashir
amrbashir previously approved these changes Mar 28, 2022
View reviewed changes
@wusyong wusyong merged commit bf3b710 into tauri-apps:dev Mar 28, 2022
@github-actions github-actions bot mentioned this pull request Mar 28, 2022
Merged
@lucasfernog lucasfernog deleted the feat/close-devtools branch March 28, 2022 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amrbashir amrbashir amrbashir left review comments

@wusyong wusyong wusyong left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasfernog @wusyong @amrbashir