feat: Implement new window requested event, closes #527 #526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fixes incorrect drop impl
atlanticaccent
changed the title
2 tasks
Remove set automation Co-authored-by: Amr Bashir <[email protected]>
keiya01
reviewed
Jun 18, 2022
wusyong
previously approved these changes
Jun 19, 2022
amrbashir
previously approved these changes
Jun 19, 2022
amrbashir
approved these changes
Jun 19, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Checklist
fix: remove a typo, closes #___, #___)Other information
The WKWebview implementation is outstanding but I'm giving it a shot.
Also couldn't test this properly as whilst testing using WSL I couldn't get popup windows to work.
Regardless of the above, these "naïve" implementations may allow for new popup windows to bypass/ignore existing webview settings. For example, they do not inherit parent window navigation handlers for example. This isn't a new thing - it's just more noticeable when implementing a feature like this where we have functions that can cancel events.