Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: html string attributes #368

Merged
merged 9 commits into from
Aug 12, 2021
Merged

feat: html string attributes #368

merged 9 commits into from
Aug 12, 2021

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Aug 12, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@wusyong wusyong marked this pull request as ready for review August 12, 2021 12:33
@wusyong wusyong requested review from a team August 12, 2021 12:33
@wusyong wusyong requested a review from a team as a code owner August 12, 2021 12:58
src/webview/mod.rs Outdated Show resolved Hide resolved
Copy link
Member

@nothingismagick nothingismagick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typos

src/webview/mod.rs Outdated Show resolved Hide resolved
src/webview/mod.rs Outdated Show resolved Hide resolved
src/webview/mod.rs Outdated Show resolved Hide resolved
src/webview/mod.rs Outdated Show resolved Hide resolved
@wusyong wusyong merged commit 02ad372 into dev Aug 12, 2021
@wusyong wusyong deleted the feat/load_html branch August 12, 2021 14:35
@github-actions github-actions bot mentioned this pull request Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants