Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Windows): resize borderless window #333

Merged
merged 10 commits into from
Jul 15, 2021
Merged

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Jul 12, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@wusyong wusyong requested a review from a team as a code owner July 12, 2021 05:13
@wusyong wusyong requested review from a team July 12, 2021 05:13
lemarier
lemarier previously approved these changes Jul 14, 2021
@wusyong
Copy link
Member Author

wusyong commented Jul 14, 2021

Don't merge it yet. I'm trying to see if there's another way to detect borderless window on linux.

..So it can be detected after the window is changed in runtime.
lemarier
lemarier previously approved these changes Jul 15, 2021
@wusyong wusyong merged commit bd10b8e into dev Jul 15, 2021
@wusyong wusyong deleted the feat/resize-borderless-on-windows branch July 15, 2021 12:50
@github-actions github-actions bot mentioned this pull request Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants