Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macos): Remove keypress handler in the webview for copy/paste/cut #328

Merged
merged 1 commit into from
Jul 7, 2021

Conversation

lemarier
Copy link
Member

@lemarier lemarier commented Jul 7, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

It should be handled by the menu.
It prevents showing a popup when we do cmd+v

@lemarier lemarier requested a review from a team as a code owner July 7, 2021 12:57
@lemarier lemarier requested a review from a team July 7, 2021 12:57
@wusyong
Copy link
Member

wusyong commented Jul 7, 2021

but is it able to cmd+x/c/v in the webview without menu items?

@lemarier
Copy link
Member Author

lemarier commented Jul 7, 2021

but is it able to cmd+x/c/v in the webview without menu items?

Nop! But if we follow macOS guidelines it SHOULD be handled trough the menus.

Also, the user still have the possibility to add the javascript if needed (by example, running in kiosk mode).

Edit; Also we now expose the clipboard API who can do a better job (paste without popup)

@wusyong wusyong merged commit 5a9df15 into dev Jul 7, 2021
@wusyong wusyong deleted the fix/paste branch July 7, 2021 13:33
@github-actions github-actions bot mentioned this pull request Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants