Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add .focus() to Webview #325

Merged
merged 12 commits into from
Jul 5, 2021
Merged

feat: add .focus() to Webview #325

merged 12 commits into from
Jul 5, 2021

Conversation

amrbashir
Copy link
Member

@amrbashir amrbashir commented Jul 4, 2021 •
edited
Loading

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@amrbashir amrbashir requested review from a team July 4, 2021 07:31
@amrbashir amrbashir changed the title feat: add focus related methods feat(windows): add focus related methods Jul 4, 2021
@amrbashir amrbashir changed the title feat(windows): add focus related methods feat: add focus related methods Jul 4, 2021
@amrbashir amrbashir requested a review from a team as a code owner July 4, 2021 09:21
@amrbashir amrbashir changed the title feat: add focus related methods feat: add focus to Webview Jul 4, 2021
@amrbashir amrbashir changed the title feat: add focus to Webview feat: add .focus() to Webview Jul 4, 2021
@wusyong wusyong merged commit 621ed1f into dev Jul 5, 2021
@wusyong wusyong deleted the feat/webview-focus branch July 5, 2021 04:39
@github-actions github-actions bot mentioned this pull request Jul 5, 2021
Merged
@huacnlee
Copy link
Contributor

huacnlee commented Oct 7, 2024

Would you please add a blur method too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amrbashir @huacnlee @wusyong