Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update custom protocol example #315

Merged
merged 4 commits into from
Jun 28, 2021
Merged

Update custom protocol example #315

merged 4 commits into from
Jun 28, 2021

Conversation

wusyong
Copy link
Member

@wusyong wusyong commented Jun 28, 2021 •
edited
Loading

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe: example update

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@wusyong wusyong requested a review from a team June 28, 2021 05:44
Ngo Iok Ui added 3 commits June 28, 2021 13:48
Cargo fmt
96e7688
Add icon as showcase
c62f8fe
Fix delay on Windows
440f1c6 
I had to debug this for hours wondering why it took so long to load the page.
And it turns out it expects "A DOT" in the url to be fast as fak boi.
Otherwise it just doesn't want to cooperate.
Why Microsoft? WHY!!??!111!!?
@wusyong wusyong requested a review from a team June 28, 2021 07:02
@lemarier lemarier self-requested a review June 28, 2021 13:04
@wusyong wusyong merged commit d9c3b9a into dev Jun 28, 2021
@wusyong wusyong deleted the fix/protocol-example branch June 28, 2021 14:02
@github-actions github-actions bot mentioned this pull request Jun 29, 2021
Merged
This was referenced Jun 29, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemarier lemarier lemarier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wusyong @lemarier