Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add #[non_exhaustive] attributes to enums #304

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@lucasfernog lucasfernog requested a review from a team as a code owner June 22, 2021 13:15
@lucasfernog lucasfernog requested a review from a team June 22, 2021 13:15
@lucasfernog
Copy link
Member Author

Note that this is a breaking change so it'll release wry v0.11. If you wanna release again soon, maybe this PR shouldn't be merged.

@wusyong
Copy link
Member

wusyong commented Jun 22, 2021

If tauri doesn't need it at the moment, I suppose we could keep the PR until next release.

@lucasfernog
Copy link
Member Author

Yeah, I only did this to prevent accidental breaking changes in the future.

@lemarier
Copy link
Member

lemarier commented Jul 7, 2021

@wusyong should we minor bump wry too?

@wusyong wusyong merged commit f07ae14 into dev Jul 8, 2021
@wusyong wusyong deleted the refactor/non_exhaustive branch July 8, 2021 14:54
@github-actions github-actions bot mentioned this pull request Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants