Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove Dispatcher and related methods, closes #290 #291

Merged
merged 8 commits into from
Jun 9, 2021

Conversation

geieredgar
Copy link
Contributor

@geieredgar geieredgar commented Jun 7, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Blocked until a new version containing #289 is released.

src/webview/mod.rs Outdated Show resolved Hide resolved
@geieredgar geieredgar marked this pull request as ready for review June 8, 2021 09:32
@geieredgar geieredgar requested a review from a team as a code owner June 8, 2021 09:33
@geieredgar geieredgar requested review from a team June 8, 2021 09:33
wusyong
wusyong previously approved these changes Jun 8, 2021
@nothingismagick
Copy link
Member

Awesome! Can you just run cargo +nightly format, then this should be good to go.

@geieredgar
Copy link
Contributor Author

@nothingismagick Running cargo +nightly fmt did not change anything, so I went ahead and fixed the clippy warning manually in the last added commit. However, the warning is not at all related to my changes. I think it is triggered by a new clippy version in the CI.

@geieredgar geieredgar changed the title refactor: remove Dispatcher and related methods refactor: remove Dispatcher and related methods, closes #290 Jun 8, 2021
Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe it's because of new clippy lint. I could merge it and fix those later.

@wusyong wusyong merged commit de4a5fa into tauri-apps:dev Jun 9, 2021
@github-actions github-actions bot mentioned this pull request Jun 9, 2021
@geieredgar geieredgar deleted the remove-dispatcher branch June 9, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants