Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(macOS): Printing (#235) #236

Merged
merged 2 commits into from
May 6, 2021
Merged

fix(macOS): Printing (#235) #236

merged 2 commits into from
May 6, 2021

Conversation

lemarier
Copy link
Member

@lemarier lemarier commented May 5, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
It prints!

@lemarier lemarier requested a review from a team as a code owner May 5, 2021 15:41
@lemarier lemarier requested a review from a team May 5, 2021 15:41
@wusyong
Copy link
Member

wusyong commented May 6, 2021

I can confirm webkit2gtk has similar API, but webview2 doesn't have it yet.
The workaround on Windows might need to use window.print() on js. wdyt?

@lemarier
Copy link
Member Author

lemarier commented May 6, 2021

I can confirm webkit2gtk has similar API, but webview2 doesn't have it yet.
The workaround on Windows might need to use window.print() on js. wdyt?

Did the window.print work on windows/linux? (I didnt tested) — Because on mac we had a blank page.

@wusyong
Copy link
Member

wusyong commented May 6, 2021

This is what it looks like on Linux
image
And here is the generated dpf file
image
(will update windows in next comment)

@wusyong
Copy link
Member

wusyong commented May 6, 2021

And here's windows
圖片
And generated pdf
圖片

So it seems fine on both. But I think it's better we still use webkitgtk api on Linux.

@wusyong wusyong merged commit 5206db6 into dev May 6, 2021
@wusyong wusyong deleted the fix/printing branch May 6, 2021 12:23
@github-actions github-actions bot mentioned this pull request May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants