Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use http instead of file for windows custom protocol workaround #173

Merged
merged 5 commits into from
Apr 20, 2021

Conversation

lemarier
Copy link
Member

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

Related to #170

@lemarier lemarier requested a review from a team as a code owner April 20, 2021 12:57
@lemarier lemarier requested a review from a team April 20, 2021 12:57
@wusyong
Copy link
Member

wusyong commented Apr 20, 2021

Are you going to push an example or is it going to be another PR?

@lemarier lemarier requested a review from a team April 20, 2021 13:30
@lemarier
Copy link
Member Author

Are you going to push an example or is it going to be another PR?

sorry got a call! pushed the example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants