Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add WindowProxy to file drop handler closure #140

Merged
merged 8 commits into from
Apr 2, 2021

Conversation

chippers
Copy link
Member

@chippers chippers commented Apr 1, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. see below
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
Needed so that we can know which window the file drop event occurred in when tauri passes the FileDropHandler to wry. Unless I misunderstand how it's supposed to know the window.

linux only for right now. i took a look at the osx implementation to make sure the proxy works there too but i immediately closed that file lol. didn't check windows either.

ready for not-wip when those 2 are supported

@chippers chippers requested review from a team April 1, 2021 18:44
@chippers chippers marked this pull request as draft April 1, 2021 18:45
@chippers
Copy link
Member Author

chippers commented Apr 1, 2021

From what I can tell, windows and osx should be supported now. I don't have a machine to test it on personally right now though. Everywhere WindowRpcHandler is used, so is WindowFileDropHandler.

@chippers chippers marked this pull request as ready for review April 2, 2021 02:02
@chippers chippers requested a review from a team as a code owner April 2, 2021 02:02
@wusyong wusyong changed the title wip: add WindowProxy to file drop handler closure feat: add WindowProxy to file drop handler closure Apr 2, 2021
@wusyong wusyong merged commit 20cb051 into dev Apr 2, 2021
@wusyong wusyong deleted the feat/file-drop-window-proxy branch April 2, 2021 05:04
@github-actions github-actions bot mentioned this pull request Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants