Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: spawn async event loop on gtk to prevent delayed messages (fix #132) #135

Merged
merged 1 commit into from
Mar 31, 2021

Conversation

aschey
Copy link
Contributor

@aschey aschey commented Mar 30, 2021

Resolves #132

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:
This change spawns an async event loop on GTK's main thread to process incoming messages from the backend instead of using the same loop that calls gtk::main_iteration(). This allows messages to be processed quickly even when the user isn't interacting with the app because messages won't be impeded while waiting for gtk::main_iteration() to complete.

@aschey aschey requested a review from a team as a code owner March 30, 2021 14:10
@aschey aschey requested a review from a team March 30, 2021 14:10
@wusyong wusyong merged commit d2a2a9f into tauri-apps:dev Mar 31, 2021
@github-actions github-actions bot mentioned this pull request Mar 31, 2021
@wusyong
Copy link
Member

wusyong commented Mar 31, 2021

Oh I forgot to mention I tested on tauri example and it seems working fine.

@aschey
Copy link
Contributor Author

aschey commented Mar 31, 2021

Awesome, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delay when processing javascript messages sent from the backend on Linux/GTK
2 participants