Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add pipe for publish check back in #131

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Conversation

jbolda
Copy link
Member

@jbolda jbolda commented Mar 28, 2021

The issue was patched in covector to run the child process as a shell if there is a pipe. So this should work again (and tests in place so it doesn't break in the future).

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

The issue was patched in covector to run the child process as a shell if there is a pipe. So this should work again (and tests in place so it doesn't break in the future).
@jbolda jbolda requested a review from a team as a code owner March 28, 2021 00:52
Copy link
Member

@wusyong wusyong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@wusyong wusyong merged commit a32829c into dev Mar 29, 2021
@wusyong wusyong deleted the chore/pipe-on-publish-check branch March 29, 2021 04:21
@github-actions github-actions bot mentioned this pull request Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants