fix(macos): prevent task object been released while executing async command #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: tauri-apps/tauri#9933 #1142 #1189 #1214
taskuntil the response closure ends, and catch exceptions from the task function call.In async mode,
taskobject may become invalid and be dropped at any moment while executing the responder. By retaining thetask, we can be sure the pointer will not point to a released object. If thetaskis marked as invalid, it will throw an exception, and we'll catch it, return the closure, and release thetaskobject.Tested with #1214, tauri-apps/tauri#9933