Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/ allow webview2 (windows) to use optional user_data folder provided by the attributes. #120

Merged
merged 5 commits into from
Mar 17, 2021
Merged

feat/ allow webview2 (windows) to use optional user_data folder provided by the attributes. #120

merged 5 commits into from
Mar 17, 2021

Conversation

lemarier
Copy link
Member

Actually only supported on Windows.
Attention the folder need to exist or webview will failed to run.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Documentation
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

  • On Windows, the default user data folder is the exe path + .WebView2.
  • This causes problems with the packaged application as the Program Files is protected and can't be used for cached data.
  • This allows us to set a different user data folder when needed.

This is only a demonstration of how we could fix it and feel free to make it better!

If you want me to do any changes let me know!

Also, this is NOT supported yet on macOS & Linux.

Thanks!

Actually only supported on Windows.
Attention the folder need to exist or webview will failed to run.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants