Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1101 #1107

Conversation

tarushnagpal
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

Other information

src/wkwebview/mod.rs Outdated Show resolved Hide resolved
src/wkwebview/mod.rs Outdated Show resolved Hide resolved
@pewsheen
Copy link
Contributor

pewsheen commented Dec 1, 2023

Oh, you need to sign your commits so we can merge them.

@tarushnagpal tarushnagpal force-pushed the fix/disable-media-dialogs-on-pre-macos14 branch from 7bde2d3 to 6cf6fb8 Compare December 1, 2023 08:20
@tarushnagpal
Copy link
Contributor Author

tarushnagpal commented Dec 2, 2023

Apparently signing a previous commit isn't possible without squashing them all, just made a new PR here #1111, sorry for the trouble

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

getDisplayMedia() does not work on MacOS Sonoma 14.0+
2 participants