Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: docs.rs macOS build failing #1033

Merged
merged 4 commits into from
Oct 10, 2023
Merged

fix: docs.rs macOS build failing #1033

merged 4 commits into from
Oct 10, 2023

Conversation

lucasfernog
Copy link
Member

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Checklist

  • This PR will resolve #___
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary
  • It can be built on all targets and pass CI/CD.

Other information

@lucasfernog lucasfernog requested a review from a team as a code owner October 9, 2023 16:33
amrbashir
amrbashir previously approved these changes Oct 9, 2023
View reviewed changes
@wusyong wusyong merged commit 0582cdf into dev Oct 10, 2023
7 checks passed
@wusyong wusyong deleted the fix/macos-docs.rs branch October 10, 2023 06:14
@github-actions github-actions bot mentioned this pull request Oct 10, 2023
Merged
@wusyong wusyong mentioned this pull request Oct 10, 2023
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wusyong wusyong wusyong approved these changes

@amrbashir amrbashir amrbashir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucasfernog @wusyong @amrbashir