refactor(android): use http scheme by default for custom protocols and add option to change it ref #994

.changes/android-protocol-http.md

@@ -0,0 +1,5 @@
+---
+"wry": minor
+---
+
+**Breaking change** Wry now defaults to `http://<scheme>.localhost/` for custom protocols on Android.

.changes/https-protocol-option-android.md

@@ -0,0 +1,5 @@
+---
+"wry": minor
+---
+
+Add `WebViewBuilderExtAndroid::with_https_scheme` to be able to choose between `http` and `https` for custom protocols on Android.

src/webview/android/mod.rs

@@ -135,16 +135,20 @@ impl InnerWebView {
       on_webview_created,
       with_asset_loader,
       asset_loader_domain,
+      https_scheme,
     } = pl_attrs;
 
+    let custom_protocol_scheme = if https_scheme { "https" } else { "http" };
+
     let url = if let Some(u) = url {
       let mut url_string = String::from(u.as_str());
       let name = u.scheme();
       let is_custom_protocol = custom_protocols.iter().any(|(n, _)| n == name);
       if is_custom_protocol {
-        url_string = u
-          .as_str()
-          .replace(&format!("{}://", name), &format!("https://{}.", name))
+        url_string = u.as_str().replace(
+          &format!("{name}://"),
+          &format!("{custom_protocol_scheme}://{name}."),
+        )
       }
       Some(url_string)
     } else {
@@ -175,13 +179,13 @@ impl InnerWebView {
           request
             .uri()
             .to_string()
-            .starts_with(&format!("https://{}.", name))
+            .starts_with(&format!("{custom_protocol_scheme}://{}.", name))
         }) {
           *request.uri_mut() = request
             .uri()
             .to_string()
             .replace(
-              &format!("https://{}.", custom_protocol.0),
+              &format!("{custom_protocol_scheme}://{}.", custom_protocol.0),
               &format!("{}://", custom_protocol.0),
             )
             .parse()

src/webview/mod.rs

@@ -349,6 +349,7 @@ pub(crate) struct PlatformSpecificWebViewAttributes {
   >,
   with_asset_loader: bool,
   asset_loader_domain: Option<String>,
+  https_scheme: bool,
 }
 
 /// Type alias for a color in the RGBA format.
@@ -848,6 +849,14 @@ pub trait WebViewBuilderExtAndroid {
   /// to `with_custom_protocol` for Android, as it changes the way in which requests are handled.
   #[cfg(feature = "protocol")]
   fn with_asset_loader(self, protocol: String) -> Self;
+
+  /// Determines whether the custom protocols should use `https://<scheme>.localhost` instead of the default `http://<scheme>.localhost`.
+  ///
+  /// Using a `http` scheme will allow mixed content when trying to fetch `http` endpoints
+  /// and is therefore less secure but will match the behavior of the `<scheme>://localhost` protocols used on macOS and Linux.
+  ///
+  /// The default value is `false`.
+  fn with_https_scheme(self, enabled: bool) -> Self;
 }
 
 #[cfg(target_os = "android")]
@@ -881,6 +890,11 @@ impl WebViewBuilderExtAndroid for WebViewBuilder<'_> {
     self.platform_specific.asset_loader_domain = Some(format!("{}.assets", protocol));
     self
   }
+
+  fn with_https_scheme(mut self, enabled: bool) -> Self {
+    self.platform_specific.https_scheme = enabled;
+    self
+  }
 }
 
 /// The fundamental type to present a [`WebView`].