fix(bundler): escape potentially problematic strings in an XML #9040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-apps#9030) - replace characters invalid in XML with their escaped form to properly bundle resources with such characters in their pathnames.
amrbashir
approved these changes
Mar 4, 2024
amrbashir
added a commit
that referenced
this pull request
Apr 18, 2024
* chore: port PR template from `dev` branch (#9004) * fix(runtime-wry): avoid panic during clipboard initialization on wayland (#9003) closes #8964 * ci: downgrade thread_local to 1.1.7 in msrv list (#9012) * Apply Version Updates From Current Changes (v1) (#9013) Co-authored-by: lucasfernog <[email protected]> * fix(bundler): escape potentially problematic strings in an XML (#9040) * fix(bundler): escape potentially problematic strings in an XML (#9030) - replace characters invalid in XML with their escaped form to properly bundle resources with such characters in their pathnames. * change file * fix(cli): use `matched_path_or_any_parents` when checking if a file is ignored (#8903) * fix: taurignore ignoreing folders not working for watch * docs: add to changes * fix: panic: path is expected to be under the root * Update taurignore-ignoring-folders-not-working-for-watch.md * Update taurignore-ignoring-folders-not-working-for-watch.md * fix(cli): migrate to stable features of `log` crate (#9119) * fix(cli): migrate to stable features of `log` crate * to_cow_str * Apply Version Updates From Current Changes (v1) (#9074) Co-authored-by: lucasfernog <[email protected]> * fix(core/path): remove suffix in basename only once (#9166) * fix(core/path): remove suffix in basename only once ref: #9064 * Update tooling/api/src/path.ts --------- Co-authored-by: Lucas Fernandes Nogueira <[email protected]> * fix(cli): Clone Options struct after mutating it. (#9188) * fix(bundler): Fix nsis resource paths on non-windows build systems. (#9281) * fix(bundler): Fix nsis resource paths on non-windows build systems. * remove leftover from alternative * fix(bundler/nsis): Don't use /R flag on installation dir (#9282) * fix(cli): upgrade heck to better support Chinese/Japanese prodcut name on Linux (#9298) * chore: fix clippy false positive (#9329) * fix(cli/info): fix crash when checking node version (#9411) closes #9396 --------- Co-authored-by: Amr Bashir <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: lucasfernog <[email protected]> Co-authored-by: bifs <[email protected]> Co-authored-by: anatawa12 <[email protected]> Co-authored-by: Lucas Fernandes Nogueira <[email protected]> Co-authored-by: Jet Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9030