Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace winapi with windows crate and use webview2-com instead of webview2 #2615

Merged
merged 10 commits into from
Sep 24, 2021

Conversation

wravery
Copy link
Contributor

@wravery wravery commented Sep 20, 2021

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Docs
  • New Binding Issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes. Issue #___
  • No

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

This goes along with similar PRs in TAO and WRY:

@wravery wravery marked this pull request as ready for review September 23, 2021 20:35
@wravery wravery requested a review from a team as a code owner September 23, 2021 20:35
@wravery wravery requested review from a team September 23, 2021 20:35
@wusyong
Copy link
Member

wusyong commented Sep 24, 2021

Looks like github actions is stuck again. The last one just checking unused deps. I'll just merge it then.

@wusyong wusyong merged commit bb00d5b into tauri-apps:next Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants