fix(api/dpi): fix toLogical and toPhysical for positions #11639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package Changes Through 441ad90No changes. Add a change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
amrbashir
requested changes
Nov 10, 2024
dgerhardt
force-pushed
the
fix-11638-position-tological-tophysical
branch
from
fb8e9ac to
4e78bb9
Compare
`toLogical` and `toPhysical` returned a position object with an incorrect `y` value. For `toLogical` this is a regression since 2.1.0. Fixes tauri-apps#11638.
dgerhardt
force-pushed
the
fix-11638-position-tological-tophysical
branch
from
4e78bb9 to
b470e13
Compare
|
@amrbashir Added the changes file. |
amrbashir
approved these changes
Nov 11, 2024
amrbashir
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toLogicalandtoPhysicalreturned a position object with an incorrectyvalue. FortoLogicalthis is a regression since 2.1.0.Fixes #11638.