Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Disable mouse event when building windows on Linux #5913

Closed
wusyong opened this issue Dec 26, 2022 · 3 comments · Fixed by #6025
Closed

[feat] Disable mouse event when building windows on Linux #5913

wusyong opened this issue Dec 26, 2022 · 3 comments · Fixed by #6025
Labels
good first issue Good for newcomers platform: Linux type: feature request

Comments

@wusyong
Copy link
Member

wusyong commented Dec 26, 2022

Describe the problem

On linux, there might have burst mouse events periodically and this could block gtk's main eventloop.
For more information, please see tauri-apps/tao#635

Describe the solution you'd like

With latest tao patch, we can call with_cursor_moved_event and set it to false as workaround. Mouse event isn't useful since webview itself can already detect such event.

Alternatives considered

Other alternatives are described in tauri-apps/tao#635.
Please comment there if you have more ideas.

Additional context

No response
@wusyong wusyong added type: feature request help wanted Help is requested to fix this issue good first issue Good for newcomers platform: Linux labels Dec 26, 2022
@amrbashir amrbashir removed the help wanted Help is requested to fix this issue label Dec 26, 2022
@shogohida
Copy link
Contributor

Hi @wusyong, can I work on this? I'd like to contribute but I will need some help because I'm new to Tauri

@wusyong
Copy link
Member Author

wusyong commented Jan 8, 2023

@shogohida I'm glad you are interested. You'll need to add a method for WindowBuilderWrapper specific to linux (and other unix except macos). And then call it during with_config call.

@shogohida shogohida mentioned this issue Jan 10, 2023
Merged
13 tasks
@shogohida
Copy link
Contributor

@wusyong
Thanks for your comment! I created a pull request according to your advice. Please check it

#6025

lucasfernog pushed a commit that referenced this issue Jan 16, 2023
@shogohida
feature: disable mouse event when building windows on Linux, closes #…
8c842a5 
…5913 (#6025)

Co-authored-by: Wu Yu Wei <[email protected]>
Co-authored-by: Lucas Nogueira <[email protected]>
Fixes #5913
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers platform: Linux type: feature request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feature: disable mouse event when building windows on Linux, closes #5913 shogohida/tauri
3 participants
@wusyong @shogohida @amrbashir