feat: add support for building with vue cli #60
Conversation
|
Something is broken, seems like it's the |
nklayman
force-pushed
the
vue-cli-support
branch
from
30ea090 to
84b0de2
Compare
|
Okay now that I've actually built the project it works. @jbolda can you review and merge please? |
| @@ -145,8 +146,11 @@ async function buildProject( | |||
| } | |||
|
|
|||
| const args = debug ? ['--debug'] : [] | |||
| const buildCommand = hasDependency('vue-cli-plugin-tauri', root) | |||
| ? (usesYarn(root) ? 'yarn' : 'npm run') + ' tauri:build' | |||
There was a problem hiding this comment.
| ? (usesYarn(root) ? 'yarn' : 'npm run') + ' tauri:build' | |
| ? (npmScript || (usesYarn(root) ? 'yarn' : 'npm run') + ' tauri:build') |
There was a problem hiding this comment.
Oh yeah that's not a bad idea. However, the npm script is expected to be used like this: yarn/npm run ${npmScript} build. Is it a bad idea to make it function slightly differently in the case of the vue cli plugin? We would have to update the docs as well. At the very least it should probably still add yarn/npm run automatically.
There was a problem hiding this comment.
I guess we could leave it the way you wrote since this action is mostly for simple apps
There was a problem hiding this comment.
Yeah I doubt people will change the script name, if someone needs to and opens and issue we can just add it then. Ready to merge IMO 👍.
|
Okay I added one, lmk if I did it right. |
|
Alright there we go, fixed now. |
If vue-cli-plugin-tauri is installed, it will run
yarn tauri:buildinstead ofyarn tauri build.