Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate updater JSON file #287

Merged
merged 3 commits into from
Oct 31, 2022
Merged

Conversation

mantou132
Copy link
Contributor

See #251

@mantou132 mantou132 force-pushed the latest-version branch 3 times, most recently from c22cf74 to 927317d Compare June 28, 2022 18:49
@mantou132
Copy link
Contributor Author

@Janaka-Steph

This comment was marked as off-topic.

@smy20011
Copy link

Is it possible to get it merged? Thank you!

@Layendan
Copy link

@lucasfernog Would you mind reviewing and merging these changes? A lot of developers, including me, would love to have this as an option.

@lucasfernog
Copy link
Member

I'll merge this but I'll leave it in the dev branch for a while. To use it in a workflow, you can just change - uses: tauri-apps/tauri-action@v0 to - uses: tauri-apps/tauri-action@dev.

@lucasfernog lucasfernog changed the title Support generate latest-version.json Generate updater JSON file Oct 31, 2022
@lucasfernog lucasfernog merged commit ce22b93 into tauri-apps:dev Oct 31, 2022
@Layendan
Copy link

Layendan commented Nov 5, 2022

So After a few tests, I have found an error.

Trying to create a release.json for multiple platforms fails after the first one.

The workflow successfully creates the release.json file for the first action that completes, but fails on the other actions of the matrix with a Unexpected token N in JSON at position 0 error.

I am using this https://github.com/tauri-apps/tauri-action#uploading-the-artifacts-to-a-release example to create the release.

Here is my workflow file: https://github.com/Layendan/NineAnimator-Tauri/actions/runs/3401839275/workflow

And here are a list of different workflows showing that the platform that finishes first is the one that succeeds while all the others fail:

Sorry for repost, original was in wrong pull/issue

@FabianLars
Copy link
Member

@Layendan Can you try the fix/json-upload branch please?

@Layendan
Copy link

Layendan commented Nov 8, 2022

I have tested the changes and it appears that it works.
Here is the workflow for it: https://github.com/Layendan/NineAnimator-Tauri/actions/runs/3415169451

Thank you for fixing it and if you don't mind, could you explain what was going wrong, I can't seem to figure it out based on the commits you made.

Is it just using octokit instead of fetch that fixes it?

@FabianLars
Copy link
Member

Is it just using octokit instead of fetch that fixes it?

That, and using the rest api instead of browser_download_url (which as its name suggests is really meant for user controlled browsers). It was basically just an authentication issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to generatelatest-version.json for Updater on release
6 participants