-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate updater JSON file #287
Conversation
c22cf74
to
927317d
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Is it possible to get it merged? Thank you! |
@lucasfernog Would you mind reviewing and merging these changes? A lot of developers, including me, would love to have this as an option. |
I'll merge this but I'll leave it in the dev branch for a while. To use it in a workflow, you can just change |
latest-version.json
So After a few tests, I have found an error. Trying to create a release.json for multiple platforms fails after the first one. The workflow successfully creates the release.json file for the first action that completes, but fails on the other actions of the matrix with a I am using this https://github.com/tauri-apps/tauri-action#uploading-the-artifacts-to-a-release example to create the release. Here is my workflow file: https://github.com/Layendan/NineAnimator-Tauri/actions/runs/3401839275/workflow And here are a list of different workflows showing that the platform that finishes first is the one that succeeds while all the others fail:
Sorry for repost, original was in wrong pull/issue |
@Layendan Can you try the |
I have tested the changes and it appears that it works. Thank you for fixing it and if you don't mind, could you explain what was going wrong, I can't seem to figure it out based on the commits you made. Is it just using octokit instead of fetch that fixes it? |
That, and using the rest api instead of browser_download_url (which as its name suggests is really meant for user controlled browsers). It was basically just an authentication issue. |
See #251