Skip to content

Commit

Permalink
fix: query max amount of release assets (#849)
Browse files Browse the repository at this point in the history
* ci: Add more architectures

* Update test-action.yml

* forgot that this change didn't make it into v2 yet

* enable release builds too

* b

* b

* b

* b

* .

* .
  • Loading branch information
FabianLars authored Jul 3, 2024
1 parent 4961ed1 commit ff07d2a
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 3 deletions.
5 changes: 5 additions & 0 deletions .changes/pull-more-assets.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
action: patch
---

Fixed an issue that caused the action to fail to upload some assets to existing releases if the workflow built the app for many architectures and debug + release mode.
2 changes: 1 addition & 1 deletion dist/index.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/upload-release-assets.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ export async function uploadAssets(
owner: owner,
repo: repo,
release_id: releaseId,
per_page: 50,
per_page: 100,
})
).data;

Expand Down
1 change: 0 additions & 1 deletion src/upload-version-json.ts
Original file line number Diff line number Diff line change
Expand Up @@ -207,6 +207,5 @@ export async function uploadVersionJSON({
});
}

console.log(`Uploading ${versionFile}...`);
await uploadAssets(owner, repo, releaseId, [{ path: versionFile, arch: '' }]);
}

0 comments on commit ff07d2a

Please sign in to comment.