Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active discovery #14

Merged
merged 1 commit into from
May 5, 2021
Merged

Active discovery #14

merged 1 commit into from
May 5, 2021

Conversation

MGatner
Copy link
Contributor

@MGatner MGatner commented May 5, 2021

  • Reworks discovery of the "current" URL for setting active Menu items
  • Fixes a bug where "active" classes relied on current_url() which has a bug when using App::$indexPage

@coveralls
Copy link

Pull Request Test Coverage Report for Build 814270102

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 794625746: 0.0%
Covered Lines: 97
Relevant Lines: 97

💛 - Coveralls

@MGatner MGatner merged commit 8589d57 into develop May 5, 2021
@MGatner MGatner deleted the discovery branch May 5, 2021 17:44
@coveralls
Copy link

coveralls commented Sep 14, 2024

Pull Request Test Coverage Report for Build 814270102

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 794625746: 0.0%
Covered Lines: 97
Relevant Lines: 97

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants