Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds #57
With a possible solution for #46
Add a additional paramter if the event should be unique.
https://github.com/tattali/CalendarBundle/compare/master...Chris53897:feature/php8-perf?expand=1#diff-e29df28b700bc5afb6adaf9697c4489ddb60b252021b353e5d078af1f9e73a9eR44
Tests:
https://github.com/tattali/CalendarBundle/compare/master...Chris53897:feature/php8-perf?expand=1#diff-176744ef8dbdd61a7010c8f3dcb08b6e4647e4dfb8d9276f764c1c6131c9c41cR46
This is a BC Break if the default Value is
false
.But maybe this is new major anyways.
For
isset
orarray_key_exists
an unique-Field likeid
has to be mandatory.But this is a BC Break as well.