Use classes to build a suite #156

extsoft · 2019-01-14T06:35:07Z

Implements #137

The change is made to build more obvious and unambiguous namespace. The rename was made using deprecation mechanism. This means the old class is still available, however, a new one is used in the code. #137

Now there are two suites (SuiteFromClasses and SuiteFromFileSystem) which can represent a SunshineSuite. SuiteFromClasses allows creation a test suite based on predefined classes. Any of these classes can be used while a custom suite (specific for a test runner) is build. Also, TestFromClass is created as we need to represent a class as an instance of SunshineTest. All relevant documentation and unit tests are updated. #137

codecov · 2019-01-14T06:37:45Z

Codecov Report

Merging #156 into master will increase coverage by 1.98%.
The diff coverage is 88.46%.

@@             Coverage Diff              @@
##             master     #156      +/-   ##
============================================
+ Coverage     70.45%   72.43%   +1.98%     
- Complexity      115      127      +12     
============================================
  Files            47       50       +3     
  Lines           511      526      +15     
  Branches          7        7              
============================================
+ Hits            360      381      +21     
+ Misses          147      141       -6     
  Partials          4        4

Impacted Files	Coverage Δ	Complexity Δ
...a/org/tatools/sunshine/core/SunshineSuiteBase.java	`100% <100%> (+100%)`	`2 <1> (+2)`	⬆️
...n/java/org/tatools/sunshine/testng/TestNGTest.java	`75% <100%> (ø)`	`3 <1> (ø)`	⬇️
...va/org/tatools/sunshine/core/SuiteFromClasses.java	`100% <100%> (ø)`	`2 <2> (?)`
...n/java/org/tatools/sunshine/core/TestFromFile.java	`66.66% <100%> (ø)`	`4 <1> (?)`
...va/org/tatools/sunshine/core/SunshineTestBase.java	`71.42% <100%> (ø)`	`3 <0> (ø)`	⬇️
...g/tatools/sunshine/testng/LoadableTestNGSuite.java	`72.5% <100%> (ø)`	`12 <1> (ø)`	⬇️
...n/java/org/tatools/sunshine/junit4/JunitSuite.java	`60% <100%> (ø)`	`4 <1> (ø)`	⬇️
...org/tatools/sunshine/core/SuiteFromFileSystem.java	`75% <75%> (ø)`	`3 <3> (?)`
.../java/org/tatools/sunshine/core/TestFromClass.java	`85.71% <85.71%> (ø)`	`4 <4> (?)`
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e33cba4...c62c73b. Read the comment docs.

extsoft · 2019-01-14T08:26:26Z

@rultor please merge.

rultor · 2019-01-14T08:27:49Z

@rultor please merge.

@extsoft OK, I'll try to merge now. You can check the progress of the merge here

rultor · 2019-01-14T08:31:01Z

@rultor please merge.

@extsoft Done! FYI, the full log is here (took me 3min)

extsoft added 2 commits January 13, 2019 22:37

Rename SunshineSuiteBase class to SuiteFromFileSystem

5b6b857

The change is made to build more obvious and unambiguous namespace. The rename was made using deprecation mechanism. This means the old class is still available, however, a new one is used in the code. #137

rultor merged commit c62c73b into master Jan 14, 2019

extsoft deleted the 137 branch January 14, 2019 08:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use classes to build a suite #156

Use classes to build a suite #156

extsoft commented Jan 14, 2019 •

edited

Loading

codecov bot commented Jan 14, 2019 •

edited

Loading

extsoft commented Jan 14, 2019

rultor commented Jan 14, 2019

rultor commented Jan 14, 2019

Use classes to build a suite #156

Use classes to build a suite #156

Conversation

extsoft commented Jan 14, 2019 • edited Loading

codecov bot commented Jan 14, 2019 • edited Loading

Codecov Report

extsoft commented Jan 14, 2019

rultor commented Jan 14, 2019

rultor commented Jan 14, 2019

extsoft commented Jan 14, 2019 •

edited

Loading

codecov bot commented Jan 14, 2019 •

edited

Loading